abhishekabhi789 / LyricsForPowerAmp

A plugin for poweramp to fetch lyrics from internet.
32 stars 2 forks source link

App crashes on search #11

Closed Asuka-pr8 closed 1 month ago

Asuka-pr8 commented 1 month ago

App crashes in coarse search and fine search if not all three fields are filled

OS:android 13 Device: Poco x5 pro

abhishekabhi789 commented 1 month ago

I couldn't reproduce this issue. Which version are you using? Is it reproducible for you? Or just happened once? Could you provide me with each field's value and search mode when the crash occurred?

Asuka-pr8 commented 1 month ago

Searching anything that could have a result does it for me

I can make an adb log file if that could help

abhishekabhi789 commented 1 month ago

That'll be very helpful.

Asuka-pr8 commented 1 month ago

crash-io-github-abhishekabhi789-lyricsforpoweramp-15_10-17-05-21_373.zip Ok so I did this using logfox and shizuku It detected the crash and here is what it gave

abhishekabhi789 commented 1 month ago

Hi, I just updated the apk in the release, https://github.com/abhishekabhi789/LyricsForPowerAmp/releases/tag/v1.1 can you try this?

Asuka-pr8 commented 1 month ago

Yeah indeed its working now But while we are at it I also did face another crash before and in older releases too for some specific results Sadly the only one I remember atm is when you search "magical" in coarse search and go down a couple of results it crashes I am pretty sure it happens with other specific results too

Either way here is a log file again incase it helped before (2)crash-io-github-abhishekabhi789-lyricsforpoweramp-16_10-09-10-46_944.zip

And lastly thanks for your hard work :D

abhishekabhi789 commented 1 month ago

Fixed that one too, the search result contains this track which has only 5 lines, meanwhile app needs 6 lines to show in the card when it is collapsed. I've re-uploaded the APK. Thank you for reporting these issues.

Asuka-pr8 commented 1 month ago

Yeah now its working

Looking nice thnx again :) Will make another issue incase I found more