search

abhishekmaha23 / RoleSim-Python

A RoleSim implementation creating using networkX for processing
2 stars 1 forks source link

Goal: Clean up the code such that Global Variables is minimalized #3

Closed BradKML closed 3 years ago

BradKML commented 3 years ago

This repo is really useful similar to https://github.com/dkaslovsky/GraphRole but it has a few issues:

  1. too many global variables, most functions are not separate into blocks
  2. there is no use of Objects and Classes compared to @dkaslovsky RecursiveFeatureExtractor and RoleExtractor
  3. storing data as NumPy files when moving data between files, instead of cross-calling functions in the same file.
abhishekmaha23 commented 3 years ago

I'd originally implemented this in a Jupyter notebook and transferred it over, so the project design is definitely not the best. This looks very nice!

BradKML commented 3 years ago

@abhishekmaha23 I don't think I code looks good either, hope we can pair program to clean this up!