Corrected and improved Find/Search behaviour

[GoogleCodeExporter]

v1.7.9.1 beta 1
Windows XP

The behavior of KeynoteNF when replacing a string by another is different from 
any other application I know.

1. open the replace dialog (Ctrl+F3)
2. fill search and replace strings and click "Find next"
3. KN selects the next occurrence of the search string
4. click on "Replace"
5. KN replaces the next occurrence, not the one found in 3.

Example: text is "occurrence", put cursor on "o", Ctrl+F3 search string="c", 
replace string="x", hit "Find next", Keynote selects "oCcurrence", hit 
"Replace", Keynote does "ocXurence".

In 4, I expect Keynote to replace the string found/selected in 3. Then KN could 
either keep the cursor in place to show to the user the results of the 
replacement or automatically select the next occurrence. Some text editors 
offer both choices: one button to replace and stay and another button to 
replace and find the next occurrence.

Original issue reported on code.google.com by davito...@gmail.com on 8 Aug 2011 at 1:03

[GoogleCodeExporter]

Sorry, I should have set this issue to "defect"

Original comment by davito...@gmail.com on 8 Aug 2011 at 1:06

[GoogleCodeExporter]

I just found about the "confirm replace" check box. This does not solve 
entirely the issue: whether or not this check box is checked, clicking on the 
"Replace" button replaces "blindly", the user has no way to know which 
character sequence is going to be replaced.

Original comment by davito...@gmail.com on 8 Aug 2011 at 3:30

[GoogleCodeExporter]

The hint says "Find next and replace" and it is acting very literally :)
The correct behaviour is as you suggest, and we find (for example) in Notepad++:

Button 'Replace' should first try to replace text at cursor and if cursor it is 
not situated in a text to be replaced then it should move to the next 
coincident text and wait for us to confirm replacement clicking in 'Replace'

As I think it is easy I will try to include it in 1.7.9. (For now I only want 
to incorporate corrections to some defects to that version)

Original comment by dpra...@gmail.com on 18 Aug 2011 at 4:44

• Changed state: Accepted
• Added labels: Milestone-1.7.9

[GoogleCodeExporter]

Fixed in revision r147

Given in this revision a better solution to problem described in Issue #327: 
Re-select Find / Replace dialog window after closing the "Not found" pop-up

Also another error related, and present also in version 1.6.5, has been 
corrected: 
To apply 'Replace All' with checks 'Search All notes' and 'Search all tree 
Nodes' set to true could lead to an endless loop.

Original comment by dpra...@gmail.com on 22 Aug 2011 at 8:06

• Changed state: Finished

[GoogleCodeExporter]

At the time I inspected that strange replace behaviour, I have decided to 
revise and rewrite, simplifying an important part of the functions 'Find' and 
'Replace'. The code was also not clear, hard to understand.
Now, 'Find' and 'Replace' lies in the same modal form, with a tab control that 
let us view a 'find' or 'replace' mode.
'Search hidden nodes' can now be set in Replace mode, too.
And a new checkbox is included, 'Selected Text', that let us to restrict the 
replacement to selected text (when we do a 'Replace All')
Another minor changes have been made trying that the overall behaviour be more 
natural.

It have been realized in revision r148

Original comment by dpra...@gmail.com on 28 Aug 2011 at 3:55

• Changed title: Corrected and improved Find/Search behaviour

[GoogleCodeExporter]

Nice :-) I'll look at your changes as soon as the new version will be available.

Original comment by davito...@gmail.com on 29 Aug 2011 at 8:06

[GoogleCodeExporter]

New changes have been realized in revision r149:

  FindAll, in resource panel, has been rewritten.
  Also, a minor bug related with FindNext when searching through a treenote without visible nodes, has been corrected

Original comment by dpra...@gmail.com on 13 Aug 2012 at 9:42

[GoogleCodeExporter]

A minor improvement, at revision r150:
Results from the same node/note are now correctly highlighted in Resource panel 
(Find). It was a functionality present from the beginning but not working.

Original comment by dpra...@gmail.com on 13 Aug 2012 at 12:54

[GoogleCodeExporter]

Good. Is there any chance to have a new release in foreseeable future?

Original comment by davito...@gmail.com on 13 Aug 2012 at 7:39

[GoogleCodeExporter]

I have just released a new version of KeyNote NF: 1.7.9 Beta 4

Could you verify and confirm if the issues are correctly resolved?
Thanks
Daniel

Original comment by dpra...@gmail.com on 7 Jan 2013 at 7:43

[GoogleCodeExporter]

Tests OK, Keynote now behaves as most other editors. Thanks for correcting this.

Original comment by davito...@gmail.com on 7 Jan 2013 at 10:09

[GoogleCodeExporter]

I just had an expected behaviour with Beta 4: my firewall warned me that 
Keynote was sending multicast IGMP packets (addresses 224.0.0.253 
239.255.255.250). Because it took me too long to investigate what this was 
about, my firewall blocked those requests automatically. But since then Keynote 
is eating 20% of my CPU although it is not in the foreground. When I bring it 
to the foreground, it takes more than 10 seconds to refresh the window 
contents. Do you know what is going on?

Original comment by davito...@gmail.com on 12 Jan 2013 at 10:27

[GoogleCodeExporter]

I checked in my firewall's logs, keynote also tried 239.255.255.250 and 
224.0.0.252

Original comment by davito...@gmail.com on 12 Jan 2013 at 10:29

[GoogleCodeExporter]

In comment 12, it should be "unexpected" instead of "expected", of course.

Original comment by davito...@gmail.com on 12 Jan 2013 at 11:28