Closed kumar8074 closed 1 month ago
Our team will soon review your PR. Thanks @kumar8074 :)
@abhisheks008 should i just place my notebook inside the existing folder or should i write my codes in the existing notebook itself?
@abhisheks008 should i just place my notebook inside the existing folder or should i write my codes in the existing notebook itself?
Add up your code in the existing files/folder. No need to remove the existing files.
@abhisheks008 But it's a complete notebook (ipynb) right and both the notebooks are completely different how can i just add my codes in the existing notebook??
You have used the same dataset right? Then download the notebook file, run the existing codes, put your model after the existing code, update the file.
You have used the same dataset right? Then download the notebook file, run the existing codes, put your model after the existing code, update the file.
No as I've asked you earlier i have used the different dataset you can see it in the chat of issue #473 Seems like you have assigned the same project to 2 persons...
@abhisheks008 But it's a complete notebook (ipynb) right and both the notebooks are completely different how can i just add my codes in the existing notebook??
My bad. If you completely remove the existing project then what about the contributor who contributed earlier that's against my ethics. It's better to put your files as well as the existing files together. In the README update your contributions along with the existing project.
@abhisheks008 But it's a complete notebook (ipynb) right and both the notebooks are completely different how can i just add my codes in the existing notebook??
My bad. If you completely remove the existing project then what about the contributor who contributed earlier that's against my ethics. It's better to put your files as well as the existing files together. In the README update your contributions along with the existing project.
got it
@abhisheks008 But it's a complete notebook (ipynb) right and both the notebooks are completely different how can i just add my codes in the existing notebook??
My bad. If you completely remove the existing project then what about the contributor who contributed earlier that's against my ethics. It's better to put your files as well as the existing files together. In the README update your contributions along with the existing project.
got it
@abhisheks008 should i close this pull request and make a new one with updates??? or is there any way to update things in this pull request only???
@abhisheks008 But it's a complete notebook (ipynb) right and both the notebooks are completely different how can i just add my codes in the existing notebook??
My bad. If you completely remove the existing project then what about the contributor who contributed earlier that's against my ethics. It's better to put your files as well as the existing files together. In the README update your contributions along with the existing project.
got it
@abhisheks008 should i close this pull request and make a new one with updates??? or is there any way to update things in this pull request only???
Create a fresh PR for this.
Pull Request for DL-Simplified 💡
Issue Title : Enhancement of Bank Loan Approval Prediction #473
Closes: #473
Describe the add-ons or changes you've made 📃
I've Enhanced the existing project by writing simpler beginner friendly code and added lots of model and ran lots of experiments to make sure that the model performs accurately.
Type of change ☑️
How Has This Been Tested? ⚙️
I've ran a lot of experiments and after careful evaluations i have concluded that this is the best performance of the model
Checklist: ☑️