abhisheksinghbaghel / azuredisk-csi-driver

Azure Disk Container Storage Interface (CSI) Storage Plugin
Apache License 2.0
2 stars 0 forks source link

chore: investigate whether special support for CSI ephemeral volume or generic ephemeral volume is required #383

Closed sunpa93 closed 2 years ago

sunpa93 commented 2 years ago

What happened:

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

nearora-msft commented 2 years ago
  1. CSI ephemeral volumes aren't supported by azure disk driver
  2. For generic ephemeral volumes, create volume and controller publish volume calls are made like any other volume created using pvc, so AzVolume and AzVolumeAttachment CRIs get created as expected. There shouldn't be a need to do any special handling for this. Tested it by deploying the changes from PR: https://github.com/abhisheksinghbaghel/azuredisk-csi-driver/pull/346 and by using this example: https://github.com/abhisheksinghbaghel/azuredisk-csi-driver/blob/master/deploy/example/nginx-pod-ephemeral.yaml. The CRIs get deleted upon the deletion of pod.
sunpa93 commented 2 years ago

Awesome. Thank you for looking into this in detail! 👍

edreed commented 2 years ago

Given the discussion in kubernetes-sigs/azuredisk-csi-driver#1189, I do not believe we should implement support for CSI Ephemeral Volumes in the Azure Disk CSI Driver.