bug: Adding PVC cleanup to SS cleanup logic, fixing concurrency issues

abhisheksinghbaghel / azuredisk-csi-driver

Azure Disk Container Storage Interface (CSI) Storage Plugin

Apache License 2.0

2 stars 0 forks source link

bug: Adding PVC cleanup to SS cleanup logic, fixing concurrency issues #393

Closed landreasyan closed 2 years ago

landreasyan commented 2 years ago

What type of PR is this?

What this PR does / why we need it: The cleanup of Stateful Sets was relying on the namespace deletion to delete the PVC-s and PV-s, thus the test was not waiting for all the resources to be deleted before completion. These changes add manual PVC and PV deletion to the Stateful Set cleanup, ensuring that all resources are deleted when the test ends.

Which issue(s) this PR fixes:

Fixes #

Requirements:

[ ] uses conventional commit messages
[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1900427908

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+11.3%) to 64.688%

Totals
Change from base Build 1899911775:	11.3%
Covered Lines:	5384
Relevant Lines:	8323

💛 - Coveralls

landreasyan commented 2 years ago

FYI, I added a temporary trigger to run the scale test on this PR to check that proper triggering of the workflow works and that the uninstall issue with the scale test is fixed. I'll be removing it before merging.

landreasyan commented 2 years ago

This PR will be rebased and merged after #397

landreasyan commented 2 years ago

Cleanup for scale test is working properly with the increased timeout changes: https://github.com/abhisheksinghbaghel/azuredisk-csi-driver/runs/5326812044