abhishekti7 / UnicornFilePicker

:eyes: A simple, documented, and contribution-friendly File Picker for Android.
Apache License 2.0
69 stars 13 forks source link

Longpress to select multiple files #4

Closed mgood7123 closed 3 years ago

mgood7123 commented 3 years ago

how would i go about implementing this feature? as a lot of file managers have this feature

abhishekti7 commented 3 years ago

Hello @mgood7123 , Thank you for using UnicornFilePicker. Will you be willing to wait for a day or two for the new release as I had this feature in the roadmap for some time and was working on it.

mgood7123 commented 3 years ago

Hello @mgood7123 , Thank you for using UnicornFilePicker. Will you be willing to wait for a day or two for the new release as I had this feature in the roadmap for some time and was working on it.

Sure :)

abhishekti7 commented 3 years ago

Hey @mgood7123, there is already an option to select multiple files in the picker. you just have to set that option in the builder like so

.selectMultipleFiles(false)

There is no need for long-press. By enabling multiple select, you can select multiple files with just a click.

The long-press is reserved for a future update where the long-press would open a bottom sheet to display the file properties and/or some file operations.

mgood7123 commented 3 years ago

Hey @mgood7123, there is already an option to select multiple files in the picker. you just have to set that option in the builder like so

.selectMultipleFiles(false)

There is no need for long-press. By enabling multiple select, you can select multiple files with just a click.

The long-press is reserved for a future update where the long-press would open a bottom sheet to display the file properties and/or some file operations.

Hmmm i think there should be an option that swaps this if desired So long press selects multiple files With an info button next to each file/folder displays that file/folder's information

So a user can easily select and multi select if desired without needing to re-open the view with different options

mgood7123 commented 3 years ago

If you want, i can try to implement something like this after the update is released :)

abhishekti7 commented 3 years ago

Sure, you can go ahead and start development on this if you like. It would be great for other developers who want the same feature

mgood7123 commented 3 years ago

I will wait until the update is released as it will be easier for you to merge cus i dont know what code has been changed/rewritten