search

abhpd-team / OEP-Frontend

Frontend React Repository for OEP | Online Exam Portal is 🔖 an easy-to-use Platform for MCQ based tests. Helping 👩🏻‍🏫 teachers by making it easier for them to take online tests and having access to a reliable platform for free.
https://oeportal.herokuapp.com/
MIT License
17 stars 9 forks source link

Able to add candidates with invalid format of id and email ( Form Control ) #28

Open sarthakmalik0810 opened 3 years ago

sarthakmalik0810 commented 3 years ago

Consider adding these checks. Also give suitable errors.

abhpd commented 3 years ago

We already have a check in-place for if the fields are empty. @sarthakmalik0810 Can you elaborate on how you encountered this?

sarthakmalik0810 commented 3 years ago

@abhpd I believe there's no check for strings with spaces. Shall I add this check?

sarthakmalik0810 commented 3 years ago

Also do you plan to add material-ui?

abhpd commented 3 years ago

@abhpd I believe there's no check for strings with spaces. Shall I add this check?

Assigning it to you.

abhpd commented 3 years ago

Also do you plan to add material-ui?

I think implementing meterial-ui will need a redesign of the UI/UX. I think the better approach will be to Create a new completely responsive interface design with material-UI.

19BCS1114 commented 3 years ago

@abhpd different institutes have different ids, so we cannot generally define what an invalid format for 'id' would be.

abhpd commented 3 years ago

@abhpd different institutes have different ids, so we cannot generally define what an invalid format for 'id' would be.

It will be a simple check to confirm a non-spaced series or letter/numbers/special characters. I think this will cover most of the university ids

abhpd commented 3 years ago

30 Partially solves the issue of empty or spaced string but still, we need a check for valid email and ID format