new Vis (outcome plot) should consider current state of the grid

abhsarma / milliways

MIT License

0 stars 0 forks source link

new Vis (outcome plot) should consider current state of the grid #20

Closed abhsarma closed 2 years ago

abhsarma commented 2 years ago

Currently the implementation which adds a new Vis component does not consider which parameter options have been excluded and/or joined. Hence, it adds estimates for each of the universes in the multiverse.

This should be implemented such that the outcomes are processed to only get the relevant filtered out universes (and combine the ones which are joined)

[x] fix initializeOutcomeData()

Currently, the desired functionality exists with on:change which calls updateOutcomeData

abhsarma commented 2 years ago

There appears to be a new bug:

[x] when there are two plots, and the grid is modified, a y-axis line is added when it should not be.
[x] when there are two plots with outcome which is not Intercept being shown in the first (left most) plot, and the grid is modified, the outcome plot changes to show data for the intercept coefficient