search

abhshkdz / HackFlowy

:notebook: Workflowy clone, built using Backbone.js & Socket.io
805 stars 151 forks source link

Bugs in Views/Task #39

Open Mr-Lopes opened 5 years ago

Mr-Lopes commented 5 years ago

Thank you for providing us a such great tool! In order to contribute, I found a couple of bugs in the views/task:

  1. the List's get method is not finding new elements (f.i. pageView.collection.get(prevSibId) ). By switching it by a filter on the array solved the issue ( f.i. pageView.collection.models.filter( (node) => node.id == prevSibId )[0].view );

  2. In the addNote method, the blur occurs after the new task is inserted, making the previous item to be set as empty. By positioning the blur before the new note fixed the problem.

Hope this helps!

abhshkdz commented 5 years ago

Thanks for trying it out @Mr-Lopes!

This is great, if you could send a quick PR with these fixes, I'm happy to merge them.

Mr-Lopes commented 5 years ago

Awesome! I am happy to help! I am still working on making it work with multiple list simultaneously on the same page. Let me finish this upgrade first, then we can merge everything - if you are interested, of course.

abhshkdz commented 5 years ago

Yup, sounds good!