search

abichinger / vue-js-cron

Renderless Vue.js cron editor
MIT License
73 stars 23 forks source link

feat(core): implements the every-at cron syntax #45

Closed barino86 closed 7 months ago

barino86 commented 8 months ago

This would close out the https://github.com/abichinger/vue-js-cron/issues/44 issue that I created the other day.

abichinger commented 8 months ago

Hello @barino86,

thank you for the PR. It seems like crontab does not support this syntax so I would prefer if this feature was disabled by default.

Which schedular are you using?

barino86 commented 8 months ago

We are using a kind of home-grown scheduler. We use this library in the UI of our application to help end users build the cron expressions they need, then we use a python library croniter to determine the next scheduled date time based on the cron expression.

barino86 commented 8 months ago

How would you like me to turn it off by default, possibly have a prop that can enable it?

abichinger commented 8 months ago

Yeah, a boolean prop would be good.

barino86 commented 8 months ago

Let me know if there is a different way you would like to see this implemented.

barino86 commented 8 months ago

Oops, going to fix the test.

barino86 commented 8 months ago

Fixed.

barino86 commented 8 months ago

I want to make that prop more dynamic by adding a watch and setting it so that it can be changed on the fly if it needs to be. working on the change for that.

barino86 commented 8 months ago

Prop is now dynamic and has been added to light and vuetify as well. I think this is ready once you call it good.

abichinger commented 7 months ago

Looks good. Thank you for your contribution.

barino86 commented 7 months ago

Thank you for being open to a new feature on an older version.