search

abichinger / vue-js-cron

Renderless Vue.js cron editor
MIT License
67 stars 23 forks source link

feat: add hebrew locale support #60

Closed a5r0n closed 2 months ago

a5r0n commented 2 months ago

Maybe it is an RTL issue, I tried to build and run the demo app, but no success 😕

a5r0n commented 2 months ago

@abichinger about the RTL issue, if you can point me with direction how to add rtl support i will be happy to implemnt this in another PR

abichinger commented 2 months ago

@a5r0n I have no experience with RTL, so I don't know where to start 🤔

a5r0n commented 2 months ago

All we need is to add dir="RTL". I will try to implement something, should I open new PR for this?

abichinger commented 2 months ago

I think no changes are necessary. I just tried to set dir="rtl" on the cron-light component and it seems to work.

<cron-light
    v-model="value"
    v-model:period="period"
    format="quartz"
    locale="he"
    @error="error = $event"
    dir="rtl"
>
</cron-light>

Result: image

Is this as it should be?

a5r0n commented 2 months ago

Yes, this is great. I was thinking maybe we should add this as a per language settings, but maybe it's out of the scope

abichinger commented 2 months ago

I was thinking maybe we should add this as a per language settings, but maybe it's out of the scope

I think this is out of scope, because of what I have read so far, the dir attribute is usually set on the html tag.

abichinger commented 2 months ago

Thanks again!

abichinger commented 2 months ago

:tada: This PR is included in version 3.0.5 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

abichinger commented 2 months ago

:tada: This PR is included in version 3.0.5 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

abichinger commented 2 months ago

:tada: This PR is included in version 5.2.0 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

abichinger commented 2 months ago

:tada: This PR is included in version 3.1.2 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

abichinger commented 2 months ago

:tada: This PR is included in version 4.0.5 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

abichinger commented 2 months ago

:tada: This PR is included in version 2.0.5 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

abichinger commented 2 months ago

:tada: This PR is included in version 5.0.5 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: