Closed dotnetCarpenter closed 7 years ago
Looks like you decided to go with approach #1 (check feed.status before using it). Agree that it is the better choice here.
I actually was in doubt and wanted to hear what you thought. But yes simpler is better. I'll delete #29 and squash the commits in #28.
BTW, there is a Squash and Merge button on the github pull page (just click the white down-arrow).
This means that github-notifier will throw errors if there is no Internet connection.
I can create a PR to deal with this, but I'm not sure what is the best way to handle this.
feed.status
before using the propertydef process_feed
and abort if disconnected ala http://stackoverflow.com/questions/20913411/test-if-an-internet-connection-is-present-in-python#20913928Ideally, github-notifier would continue to pull, so that it will get results when the Internet connection is back up.