search

abiczo / github-notifier

Github updates notifier for Linux
57 stars 8 forks source link

Fix 27 hasattr #28

Closed dotnetCarpenter closed 7 years ago

dotnetCarpenter commented 7 years ago

This PR fixes #27 by checking if feed.status exist, via hasattr, before using it to log the request.

It also adds a debug log level.

abiczo commented 7 years ago

Thanks! Looks good to me, just one request. Could you collapse this into a single commit since it seems like this is one logic unit of change.

dotnetCarpenter commented 7 years ago

The PR is squashed into one commit and ready for merge :smiley_cat:

abiczo commented 7 years ago

Thank you! Also thanks for the tip on the Squash and merge button, didn't know it existed.