Enable blog entries - Githubissues

abiczo / github-notifier

Github updates notifier for Linux

57 stars 8 forks source link

Enable blog entries #4

Closed kevinjalbert closed 12 years ago

kevinjalbert commented 12 years ago

Close #2

Add:

Option to enable notifications of new blog entries
GitHub blog entry author icon to use the octocat.png
GitHub blog entry author information to be 'GitHub Blog'

Refactor:

How octocat.png path is used (now just uses the absolute path)

abiczo commented 12 years ago

Sweet, thanks! I don't have a Linux box right now so unfortunately I can't test it, but it looks good and I'm assuming it works, so I'm going to merge this. I have just one minor comment inline, please see above. Could you possibly address that before I merge this in? Or if it would be easier to merge this now and then merge another diff for that comment that's fine too, just let me know which one would you prefer.

Thanks again for doing this!

kevinjalbert commented 12 years ago

I'll make the fix. You are right, just the abspath is needed.

kevinjalbert commented 12 years ago

Should be good to go now.

Also it works on my end (Using Archlinux with gnome-shell).

abiczo commented 12 years ago

Sweet, thanks!