abiczo / github-notifier

Github updates notifier for Linux
57 stars 8 forks source link

Filtering authors and/or projects #6

Closed kevinjalbert closed 12 years ago

kevinjalbert commented 12 years ago

Close #5

Add:

Refactor:

abiczo commented 12 years ago

Nice job, thanks! Couple of suggestions inline. They're quite nit-picky, sorry about that. Also as a general comment the code use single quotes everywhere. I'm fine with using double quotes too, but I'd prefer it to be consistent. Can you either change the old code to use doulbe quotes or change your diff to single quotes, whichever you prefer?

kevinjalbert commented 12 years ago

I took your comments into consideration. They are addressed in the 9e8fc15 commit.

In addition, I added another small feature in the 6ce4ad1 commit. It gives the system tray menu more purpose and eventually I will add the ability to disable/enable filtering from the tray.

abiczo commented 12 years ago

Nice job, thanks!