abidinamdar / gmapcatcher

Automatically exported from code.google.com/p/gmapcatcher
1 stars 0 forks source link

gps update timeout #213

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
hi

i have added timeout for gps updates if user moving the map.
you need gps or gps simulator to see changes.

enable "gps center" mode and try to move the map. map will not centered several 
seconds. after timeout it will function as user selected.

Original issue reported on code.google.com by pokr...@gmail.com on 30 Aug 2010 at 5:08

GoogleCodeExporter commented 8 years ago
Please add your changes to the trunk, in that way we can discuss the details.

This should be a new GPS mode it should not affect the behavior of the existing 
modes

Original comment by heldersepu on 30 Aug 2010 at 1:14

GoogleCodeExporter commented 8 years ago
hi

i have add changes to trunk.

and starting from r1011 there is following errors:

1. maps.py in gps_callback(self, coord, mode)
location is updated only first time.
i've commented out code that produce error

2.
Traceback (most recent call last):
  File "maps.py", line 744, in expose_cb  self.draw_overlay()
  File "maps.py", line 835, in draw_overlay  self.showMarkers, self.gps
  File "gmapcatcher\widDrawingArea.py", line 240, in draw_overlay
    draw_image(location, img, GPS_IMG_SIZE[0], GPS_IMG_SIZE[1])
NameError: global name 'draw_image' is not defined

even after fixing it current gps location marker does not drown in correct 
place.

Original comment by pokr...@gmail.com on 31 Aug 2010 at 12:46

GoogleCodeExporter commented 8 years ago
could you provide more complete tracebacks than that, to allow us to identify 
the precise bugs?

hopefully I've identified the bugs now; as my gpsd seems to have difficulty 
sending its messages to gmapcatcher perhaps you could check

Original comment by Mark111...@gmail.com on 31 Aug 2010 at 9:13

GoogleCodeExporter commented 8 years ago
under win xp r1023 works, but under ubuntu 10.10 can't scroll the map by mouse

Original comment by pokr...@gmail.com on 31 Aug 2010 at 9:39

GoogleCodeExporter commented 8 years ago
fixed the problem in r1023.

starting from r1011 location marker not gps received position (blue cross in 
attached file) of screen.
marker on left side of window.

Original comment by pokr...@gmail.com on 31 Aug 2010 at 10:07

GoogleCodeExporter commented 8 years ago
"location marker not gps received position"
  Say What???

Original comment by heldersepu on 31 Aug 2010 at 12:17

GoogleCodeExporter commented 8 years ago
In r1023 what you commented "## following code does not working" is something 
that does not affect the program and will be useful very soon.

Original comment by heldersepu on 31 Aug 2010 at 12:27

GoogleCodeExporter commented 8 years ago
I been looking at the code and I do not understand what you are trying to do... 
your changes should NOT affect the behavior of GPS_CENTER or GPS_ON_SCREEN.

I just added a new option GPS_TIMEOUT and moved your code to the appropriate 
section, see r1026 for more details

Original comment by heldersepu on 31 Aug 2010 at 12:59

GoogleCodeExporter commented 8 years ago
>"location marker not gps received position"
>  Say What???

check the attached screen shots of r1010 and r1011 with fixed bugs as r1024.
gps mode is "gps center".
red marker not in the center. it always on the left side starting from r1011

Original comment by pokr...@gmail.com on 31 Aug 2010 at 1:19

GoogleCodeExporter commented 8 years ago
that's definitely an improvement; I'm thinking longer-term at some stage some 
kind of config setting - I seem fond of config settings :-D - as a modification 
of center/onscreen would be worthwhile, although definitely for now GPS_TIMEOUT 
sounds safest :-)

Original comment by Mark111...@gmail.com on 31 Aug 2010 at 1:22

GoogleCodeExporter commented 8 years ago
 After looking at the code & re-reading this issue, my guess is: 
You want to recenter the GPS marker IF AND ONLY IF the program has been idle 
for more than 3 seconds.

Original comment by heldersepu on 31 Aug 2010 at 1:24

GoogleCodeExporter commented 8 years ago
> I been looking at the code and I do not understand what you are trying to 
do... 
> your changes should NOT affect the behavior of GPS_CENTER or GPS_ON_SCREEN.

they are did not affected to the behavior of GPS_CENTER or GPS_ON_SCREEN.
yeah, my code is little bit ugly, but i will explain reason of this changes.

try to attach a gps with 1 sec update and set GPS_CENTER mode.
than try to scroll the map. map will flicks.
my code just adds small delay. if you release the dragged map, after 3 secs it 
will continue in normal GPS_CENTER or GPS_ON_SCREEN mode.

Original comment by pokr...@gmail.com on 31 Aug 2010 at 1:27

GoogleCodeExporter commented 8 years ago
> You want to recenter the GPS marker IF AND ONLY IF the program has been idle 
for more than 3 seconds.

yeah, you are right.
only on map scrolling, not after zooming or after any other activity.

Original comment by pokr...@gmail.com on 31 Aug 2010 at 1:31

GoogleCodeExporter commented 8 years ago
pokrash, could you check the centering of the gps marker now? Hopefully I found 
the bug

Original comment by Mark111...@gmail.com on 31 Aug 2010 at 1:43

GoogleCodeExporter commented 8 years ago
the GPS_TIMEOUT should be all good now, please take a look at r1028

Original comment by heldersepu on 31 Aug 2010 at 1:55

GoogleCodeExporter commented 8 years ago
gps marker position is correct now.

and i have one idea to replace marker to arrow pointing direction of moving.
but i think it's not so simple task.
there will need some coordinates filtering and a lot of testing.

Original comment by pokr...@gmail.com on 31 Aug 2010 at 1:56

GoogleCodeExporter commented 8 years ago
best is to test before committing :-)

Original comment by Mark111...@gmail.com on 31 Aug 2010 at 2:00

GoogleCodeExporter commented 8 years ago
replace GPS marker to arrow pointing direction of moving = Issue 78

Original comment by heldersepu on 31 Aug 2010 at 2:05

GoogleCodeExporter commented 8 years ago
I guess this feature is completed, Right?

Original comment by heldersepu on 2 Sep 2010 at 12:29

GoogleCodeExporter commented 8 years ago

Original comment by heldersepu on 29 Mar 2011 at 2:17