Complete.html as a separate page

abidlabs / zakat.fyi

A well-designed modern zakat web app

https://zakat.fyi

MIT License

9 stars 1 forks source link

Complete.html as a separate page #95

Closed abidlabs closed 4 years ago

abidlabs commented 4 years ago

to allow analytics on how many people completed the form

abidlabs commented 4 years ago

Alternatively, we track the number of hits on the calculate button: https://developers.google.com/analytics/devguides/collection/analyticsjs/events

abidlabs commented 4 years ago

Debug this as we don't see it on Google Analytics. @itinawi maybe we can look at this together

itinawi commented 4 years ago

Are you adding the Google Analytics script tag on the new pages? @abidlabs

 <script async src="https://www.googletagmanager.com/gtag/js?id=UA-166050306-1"></script> <script> window.dataLayer = window.dataLayer || []; function gtag(){dataLayer.push(arguments);} gtag('js', new Date()); gtag('config', 'UA-166050306-1'); </script>

abidlabs commented 4 years ago

Yeah it's right under here: https://github.com/abidlabs/zakat.fyi/blob/05330e116b3927748b5b4741f675de5b74752260/js/index.js#L11

abidlabs commented 4 years ago

Do you have any idea what might be happening?

abidlabs commented 4 years ago

It's working. See:

itinawi commented 4 years ago

Oh yeah the event was working but i thought this was for a separate page as the title suggested. Good to see it working!