search

abielzulio / chatgpt-raycast

ChatGPT raycast extension
https://www.raycast.com/abielzulio/chatgpt
MIT License
574 stars 47 forks source link

feat: move model selection to ask detail view #22

Closed kale5195 closed 1 year ago

kale5195 commented 1 year ago

Hi Abiel,

I made some changes to move model selection from right corner into ask detail view.

Here is a video for this feature:

I use Command + Shift + U to trigger the ask command

https://user-images.githubusercontent.com/95554104/223593998-0800e96d-39ea-423d-b77e-7af9db48c44c.mov

Not sure if you like this PR... Feel free to close it if you dislike or you can implement your own..

abielzulio commented 1 year ago

What's the main reason of this PR? Which part of the current layout/experience that you don't like/missing? Could you elaborate more on that?

kale5195 commented 1 year ago

Currently, in order to select a model, you have to click command + P. However, with this PR, this step is removed.

Furthermore, when selecting long text, it can be difficult to display it in the search text input. It would be better to display it in the item detail view.

abielzulio commented 1 year ago

Currently, in order to select a model, you have to click command + P. However, with this PR, this step is removed.

Yes, the current flow does need an extra step to select the model but this gives the user flexibility to change their model on-the-fly (quicker) rather has a fixed model selection from the beginning like yours.

Furthermore, when selecting long text, it can be difficult to display it in the search text input. It would be better to display it in the item detail view.

How do you handle conversation (multiple on-going chat) then?

I think I have a better proposal for this one. Hold on.

kale5195 commented 1 year ago

has a fixed model selection from the beginning like yours.

Mine has same flexibility, it just move the dropdown into view. If there is no matched prompts, it will became default model. Also you can long press command key to apply custom prompts

abielzulio commented 1 year ago

has a fixed model selection from the beginning like yours.

Mine has same flexibility, it just move the dropdown into view. If there is no matched prompts, it will became default model.

Also you can long press command key to apply custom prompts

Yes, but how do you handle the conversation then?

kale5195 commented 1 year ago

@abielzulio I didn't change the conversation part, after clicking enter, it will reuse the conversation part you build

abielzulio commented 1 year ago

@kale5195

Checkout my proposal on feat/use-full-input-init branch and please let me know what you think of that.

I agree with you that sometimes the user needs a bigger input space when asking a question but disagree with moving the question from the search bar into the detailed view making the upcoming conversation doesn't look seamless and consistent.

kale5195 commented 1 year ago

👍🏻 use full input solve the problem of large text, but is it possible to add a shortcut for model selection?

I can close this PR for now