[Yahoo Android] Review Project 2 - Google Image Search

[abiligiri]

/cc @nesquena @timothy1ee

• Search and options work
• Using infinite scroll
• Using volley so that will have to be added as a library project to build code

Planned enhancements

• Better keyboard handling on SearchActivity
• Is displaying full image required ? The walk through shows this, but the assignment doesn't specify it.

[nesquena]

Anand, :+1: Looks good overall. I have provided a detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[abiligiri]

@nesquena One question I have here is the way data is sent back from OptionsActivity to SearchActivity. I have defined a model for the search query with (query string, offset, result size and other options). I pass this model as a serializable extra to OptionsActivity. The options are presented on screen and as user makes changes, the model is updated to reflect the user choice. The only way to go from OptionsActivity to SearchActivity is by using the back button and this is the only place to set the result. Is this the right approach ? Is there an expectation on the Android platform that back action doesn't commit the user changes ?

[nesquena]

Is there an expectation on the Android platform that back action doesn't commit the user changes ?

Yeah, you might consider adding a "Save" button to the settings panel rather than using "back" to record my filter. Back does often mean "cancel" in the Android world. Save would then return the result back for the filters back to the search activity.