search

abiligiri / A3-TwitterClient

0 stars 0 forks source link

[Yahoo Android] Review Project 4 - Twitter Client with Fragments #3

Open abiligiri opened 10 years ago

abiligiri commented 10 years ago

/cc @nesquena I have implemented the Fragments , ActionBar tabs,Tab Switching etc. Also implemented the MentionsTimelineFragment. I am also using the EndlessScrollListner and that doesn't seem to be firing the very first time.

If I move the initial loading of tweets to outside the scroll listener, then I keep seeing the same 25 tweets being downloaded over and over again on scrolling. The getTweets() method is always called with the same tweetID

nesquena commented 10 years ago

You are missing a few of the required user stories (around the user profile view for the logged in user and where you can view the user profile for any user in the feed), which you may be aware of. Please ping me when these are completed. Get those required stories working before going back to fixing endless scrolling.

If I move the initial loading of tweets to outside the scroll listener, then I keep seeing the same 25 tweets being downloaded over and over again on scrolling. The getTweets() method is always called with the same tweetID

Why do you have this call which would always load the first page every time?

abiligiri commented 10 years ago

I was able to the following stories working Includes all user stories from Week 3 Twitter Client User can switch between Timeline and Mention views using tabs. User can view their home timeline tweets. User can view the recent mentions of their username. User can click icon on Action Bar to view their profile User can see picture, tagline, # of followers, # of following, and tweets on their profile. User can click on the profile image in a tweet to see that user's profile.

I also fixed the endless scroll. I was not passing the max_id properly to the async-http. I was using get(url, handler) instead of get(url, params, handler)

Without https://github.com/abiligiri/A3-TwitterClient/blob/master/src/com/example/twitterclient/fragments/TweetsListFragment.java#L49 nothing will show up in the list view the very first time app is launched. I guess on subsequent launches loading of persisted tweets should trigger scroll listeners. Even though I have implemented persistence, it doesn't work properly and I run into foreign key issues when I try to make the tweetId and userId as unique keys. So I have disabled loading persisted tweets.

nesquena commented 10 years ago

OK thanks for the update, will review tomorrow. Could you post more specific errors for the persistence stuff, would love to help you get that working.

abiligiri commented 10 years ago

I wanted to know if what I have submitted is acceptable for the required stories. I will discuss with you tomorrow before/after class about the persistence issue

nesquena commented 10 years ago

It looks good in terms of required user stories (persistence is optional task), will be doing a full review tonight.

nesquena commented 10 years ago

:+1: Project looks good. A few notes:

I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.