Layout compatibility using event.key

abinavseelan / react-input-trigger

React component for handling character triggers inside textareas and input fields. 🐼

MIT License

88 stars 20 forks source link

Layout compatibility using event.key #7

Closed Razboi closed 1 year ago

Razboi commented 6 years ago

Using event.keyCode limits the keyboard layout compatibility. Added a trigger.key property for triggering with event.key

Razboi commented 6 years ago

Ops. Messed up building for my own project. It's reverted now

Teippo2020 commented 5 years ago

To the maintainer, are there any plans to merge this feature? The library basically doesn't work on MAC for the character @

abinavseelan commented 5 years ago

Apologises for not getting back to this earlier. 😞 Thank you so much for raising this fix @Razboi 🙂

Since this is a breaking change, can we assimilate this change into https://github.com/abinavseelan/react-input-trigger/tree/pre-release/2.0.0. This branch has some more breaking changes that fix non-standard input elements as highlighted in #10 and would be the next major version release for this package.

Teippo2020 commented 5 years ago

That would be awesome! In the meantime (because I needed this feature so much) I created a fork and published it to npm, just in case anyone needs this feature before the release.

https://www.npmjs.com/package/react-input-trigger-fork