abingham / emacs-ycmd

Emacs client for ycmd, the code completion system.
MIT License
383 stars 46 forks source link

Add structure for request data #417

Closed ptrv closed 7 years ago

ptrv commented 7 years ago

This PR adds a defstruct for the location and content request data that is needed in ycmd--request. This encapsulates and makes the creation of the request data more descriptive

abingham commented 7 years ago

The change looks good. Any idea why the travis test is failing?

ptrv commented 7 years ago

Some of the tests are flaky and fail sometimes. Restarted the failing one, hopefully it runs through. I have the travis tests also running for my fork and there it succeeded.

ptrv commented 7 years ago

Test pass now.

I'll have a look into the flaky tests sometimes soon