abingham / emacs-ycmd

Emacs client for ycmd, the code completion system.
MIT License
384 stars 46 forks source link

Minor README formatting update. #422

Closed ptrv closed 7 years ago

ptrv commented 7 years ago

@zzbot r+

Valloric commented 7 years ago

@ptrv Something is broken here. Zzbot will respond within seconds to commands. Looking at your queue, it doesn't see this PR as being approved or pending.

@abingham Can you confirm successful webhook delivery to homu? Go to repo settings -> webhooks -> edit. You should be able to see "recent deliveries" at the bottom of the page. There should be green checkmarks next to the latest ones. Also verify that you've set up delivery of events: Issue Comment, Pull Request, Push, Status.

abingham commented 7 years ago

Can you confirm successful webhook delivery to homu?

I see the initial failed delivery (i.e. before the homu endpoint was active), 30 to 40 successful calls between 22:41 and 23:20 CEST on 14.5, 3 failed calls in a row between 23:21 and 23:26, then about 15 successes up to 00:42 on 15.5.

Also verify that you've set up delivery of events: Issue Comment, Pull Request, Push, Status.

Those are all active (and they're the only active ones).

abingham commented 7 years ago

@Valloric @ptrv I do see that @zzbot has not accepted my invitation to be a collaborator:

screen shot 2017-05-15 at 07 59 43

Could this be the issue?

Valloric commented 7 years ago

@abingham That is indeed the issue, my bad! Try using at-zzbot r+ again.

abingham commented 7 years ago

@zzbot r+

zzbot commented 7 years ago

:pushpin: Commit 888fee3 has been approved by abingham

zzbot commented 7 years ago

:hourglass: Testing commit 888fee345ad76652dd7aadaa1646421a3e1e3df3 with merge bcb26704cb9149ff6fd13ece07243891bef6e4a5...

ptrv commented 7 years ago

@Valloric @abingham Nice, it works

zzbot commented 7 years ago

:sunny: Test successful - status-travis Approved by: abingham Pushing bcb26704cb9149ff6fd13ece07243891bef6e4a5 to master...

abingham commented 7 years ago

Super cool! I had a gerrit/jenkins workflow at my last proper job that worked like this, and I loved it. Thanks again for helping set this up.

Valloric commented 7 years ago

Happy to help! :)