abingham / emacs-ycmd

Emacs client for ycmd, the code completion system.
MIT License
384 stars 46 forks source link

Refactor synchronous requests #423

Closed ptrv closed 7 years ago

ptrv commented 7 years ago

Simplify ycmd--request by removing sync option, so that the function always returns a deferred object. To have synchronous request use modified deferred:sync! version ycmd-deferred:sync! with the difference that the interval is smaller for the checks and we use accept-process-out for waiting, which also used in url-retrieve to wait for the synchronous request to finish.

With these changes I noticed that test were no tests failing anymore with undefined reason, which needed to be re-triggeredh until they passed.