search

abingham / emacs-ycmd

Emacs client for ycmd, the code completion system.
MIT License
383 stars 46 forks source link

Minor optimization in company-ycmd--construct-candidates #427

Closed ptrv closed 7 years ago

abingham commented 7 years ago

@zzbot r+

zzbot commented 7 years ago

:pushpin: Commit 6746c55 has been approved by abingham

zzbot commented 7 years ago

:hourglass: Testing commit 6746c557514bff9bc59f4fb60d219a72d3acbcb3 with merge b7ad7c440dc3640a46291a9acf98e523272e302b...

zzbot commented 7 years ago

:sunny: Test successful - status-travis Approved by: abingham Pushing b7ad7c440dc3640a46291a9acf98e523272e302b to master...

ptrv commented 7 years ago

No I haven't experienced a performance problem, just wanted to add a test case so it's covered.

abingham commented 7 years ago

OK. I'm pretty ambivalent about that. If you have the time to add a test case, it wouldn't hurt. But it doesn't seem critical.

On Thu, May 25, 2017 at 12:03 PM Peter Vasil notifications@github.com wrote:

No I haven't experienced a performance problem, just wanted to add a test case so it's covered.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/abingham/emacs-ycmd/pull/427#issuecomment-303973458, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE1eObTC4dbR6x_gmsF79RgTli5t_fvks5r9VIJgaJpZM4NhkXL .