search

abingham / emacs-ycmd

Emacs client for ycmd, the code completion system.
MIT License
384 stars 46 forks source link

Don't provide `run' and keep "test/" out of `load-path' #455

Closed tarsius closed 6 years ago

tarsius commented 6 years ago

Since you don't (require 'run) you also don't have to provide that. I noticed that you provide this feature because another package provides the same.

It's also a good idea to keep the test directory out of the load-path, which is being done using the .nosearch file.

I have not run the tests (I was expecting they would be run on travis), so you should to that before merging.

abingham commented 6 years ago

This all sounds reasonable to me.

@ptrv I think you know more about this area than I do. What do you think?

ptrv commented 6 years ago

LGTM

@abingham I am wondering why the travis tests are not run for this PR

@zzbot r=abingham

zzbot commented 6 years ago

:pushpin: Commit af6da02 has been approved by abingham

zzbot commented 6 years ago

:hourglass: Testing commit af6da02824a508742ee43f9ad96303f7f2be9beb with merge 1a25cb4b3f90108215b79c73a821c3174bbd1f3e...

tarsius commented 6 years ago

Homu (aka @zzbot) seems interesting...

zzbot commented 6 years ago

:broken_heart: Test failed - status-travis

ptrv commented 6 years ago

@zzbot retry

zzbot commented 6 years ago

:hourglass: Testing commit af6da02824a508742ee43f9ad96303f7f2be9beb with merge 7f394d02f6f3149b215adcc96043c78d5f32d612...

zzbot commented 6 years ago

:sunny: Test successful - status-travis Approved by: abingham Pushing 7f394d02f6f3149b215adcc96043c78d5f32d612 to master...

abingham commented 6 years ago

I am wondering why the travis tests are not run for this PR

@ptrv That is odd. There are a few conditions under which travis won't try a build, but none of them seem to apply here.