search

abingham / emacs-ycmd

Emacs client for ycmd, the code completion system.
MIT License
384 stars 46 forks source link

On windows, syntax errors are not being reported #458

Closed ashwinravianandan closed 6 years ago

ashwinravianandan commented 6 years ago

Cause: location.filpath contains mixed seperator. for example /project/root\relative\path\to\file This results in the filteration of all results reported by ycmd.

abingham commented 6 years ago

Do you know why this is failing the CI tests? Do they pass on your system?

justinjk007 commented 6 years ago

Ok So I am stuck with this problem now, ycmd is not reporting any errors on windows, But the reason why this build on CI is filing because 2 tests for Javascript is failing.

Applied 6 changes
   passed  70/72  ycmd-test-refactor-rename-simple
   passed  71/72  ycmd-test-semantic-completer-available
   passed  72/72  ycmd-test-semantic-completer-not-available
Ran 72 tests, 70 results as expected, 2 unexpected (2017-12-04 19:35:58+0000)
2 unexpected results:
   FAILED  ycmd-test-get-completions-javascript
   FAILED  ycmd-test-get-defined-subcommands-javascript
make: *** [test] Error 1
abingham commented 6 years ago

@justinjk007 Does this PR address the immediate problems you were experiencing? I'm happy to merge it it, but it fell off my radar when @ashwinravianandan didn't respond.

Also, FWIW, I think I'm close to sorting out the test failures.

justinjk007 commented 6 years ago

Can confirm the PR is definitely working.

abingham commented 6 years ago

Thanks for helping me sort through this, @justinjk007!