abingham / traad

An JSON+HTTP server for the rope Python refactoring library
MIT License
107 stars 20 forks source link

Three undefined names #100

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

cmp() is present in Python 2 but was removed in Python 3.

flake8 testing of https://github.com/abingham/traad on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./distribute_setup.py:476:20: F821 undefined name 'cmp'
            return cmp(dir1.name, dir2.name)
                   ^
./traad/app.py:325:12: F821 undefined name 'request'
    args = request.json
           ^
./traad/app.py:330:20: F821 undefined name 'context'
        'results': context.workspace.get_definition_location(
                   ^
3     F821 undefined name 'cmp'
3
abingham commented 6 years ago

The first one is protected by a version check. The other two should be fixed as of dd766c7adb663866f229fe4b45ee4391da2128b3. Thanks!