abingham / traad

An JSON+HTTP server for the rope Python refactoring library
MIT License
107 stars 20 forks source link

Add extra options for `rename_view` #102

Closed jcaw closed 6 years ago

jcaw commented 6 years ago

The Rope rename command takes a few optional parameters that define how it will rename occurrences. The current implementation restricts renamings to ignore docstrings, comments and occurrences higher/lower in the hierarchy (e.g. in superclasses & subclasses). It also ignores unsure occurrences. This is a small modification that exposes these options in the API so the client can specify them.

The new parameters are optional and will default to the old values, so this won't change how this method interacts with existing clients.

jcaw commented 6 years ago

I also have a branch open here that modifies emacs-traad to take advantage of these new parameters.

abingham commented 6 years ago

This change mostly looks good, it just needs a few minor changes. Thanks!

abingham commented 6 years ago

I also have a branch open here that modifies emacs-traad to take advantage of these new parameters.

I'll be delighted to merge that in as well once the server is ready.

jcaw commented 6 years ago

Awesome! I'll implement the changes and push them in.

jcaw commented 6 years ago

Changes pushed. :)

jcaw commented 6 years ago

Sorry about that - unsure parameter fix pushed in.

abingham commented 6 years ago

Awesome, thanks!

jcaw commented 6 years ago

No worries!