search

abingham / traad

An JSON+HTTP server for the rope Python refactoring library
MIT License
107 stars 20 forks source link

rope move command #99

Closed talwrii closed 6 years ago

talwrii commented 6 years ago

Move top-level objects between files.

https://github.com/python-rope/rope/blob/master/rope/refactor/move.py

Note the "basic." in one of the tests.

I've implemented the emacs client side code for this, but not the vim code as I do not use vim for coding.

Tox test pass (but I did not run against python3.4 as it was difficult to get this working on my machine).

talwrii commented 6 years ago

Branch implementing this feature in emacs:

https://github.com/talwrii/emacs-traad/tree/talwrii--2017-12-11--move

I presume it makes sense to wait until this pull request is resolved before creating another pull request for emacs-traad?

abingham commented 6 years ago

Thanks, this looks great! Sorry for the delay in merging this in. I was traveling for work and didn't have much time to look at other stuff.

As for the emacs client, go ahead and create that PR any time.