abinit / abipy

Open-source library for analyzing the results produced by ABINIT
http://abinit.github.io/abipy
Other
117 stars 96 forks source link

Reintroduce support for Python 3.8? #268

Closed mbercx closed 1 year ago

mbercx commented 1 year ago

In the context of the following discussion: https://github.com/aiidateam/aiida-common-workflows/pull/314#issuecomment-1686606367,

we were wondering if it would be possible to reintroduce support for Python 3.8 for abipy? I had a look, and support seems to have been dropped in the following commit: https://github.com/abinit/abipy/commit/febc8bfc8dd7b8f566849a20d41c83682ca284ae

Is there any reason besides usage of PEP585 type hinting to remove Python 3.8 support? It seems most modules already have the required from __future__ import annotations import to fix this, only the abipy.flowtk.wrappers.py module seems to miss it. At least my tests on aiida-common-workflows run fine when I add the __future__ import to this module.