abinoda / label-when-approved-action

GitHub Action that labels approved pull requests
MIT License
191 stars 130 forks source link

Use Alpine Docker image #12

Closed rciovati closed 5 years ago

rciovati commented 5 years ago

The Alpine Docker image is much smaller compared to the Debian one (~5.5MB vs 55MB) and generally package installation is faster. With this changes we should be able to speedup the image build phase and thus to make the overall Action execution faster.

Related to #6.

Maikel-Koek commented 5 years ago

Hi @rciovati, My action using this package now fails, see the following error:

Run pullreminders/label-when-approved-action@master
  env:
    APPROVALS: 1
    GITHUB_TOKEN: ***
    ADD_LABEL: automerge
/usr/bin/docker run --name df047b634fecb42ad8b67a29a6270d884_5103d0 --label 10865d --workdir /github/workspace --rm -e APPROVALS -e GITHUB_TOKEN -e ADD_LABEL -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/automation-test/automation-test":"/github/workspace" 10865d:f047b634fecb42ad8b67a29a6270d884
base64: unrecognized option: decode
BusyBox v1.30.1 (2019-06-12 17:51:55 UTC) multi-call binary.

Usage: base64 [-d] [FILE]

Base64 encode or decode FILE to standard output
    -d  Decode data
##[error]Docker run failed with exit code 1

My .yml configuration is nothing special:

name: Add Approved Label

on:
  pull_request_review:
    types:
      - submitted
      - edited
      - dismissed

jobs:
  add-approved-label:
    runs-on: ubuntu-latest
    steps:
      - name: "Add Approved Label"
        uses: "pullreminders/label-when-approved-action@master"
        env:
          APPROVALS: "1"
          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
          ADD_LABEL: "automerge"

Does this have something to do with switching to the Alpine Docker?

Maikel-Koek commented 5 years ago

Confirmed: I just switched to using one commit earlier (pullreminders/label-when-approved-action@99ed75464e63cb81a615008b5f8e4095222620d1) and my action successfully completed.

rciovati commented 5 years ago

@Maikel-Koek looks like there is already a PR to fix that #13, sorry for the troubles. Will look into some automatic testing infrastructure to make sure I don't break stuff every time. 😅

On a side note, I would not recommend using master but rather using a tag which is gives you stability.