Publish docker image to docker hub

abinoda / label-when-approved-action

GitHub Action that labels approved pull requests

MIT License

191 stars 130 forks source link

Publish docker image to docker hub #6

Closed rciovati closed 3 years ago

rciovati commented 5 years ago

Every time a PR is approved it takes around 1 minute to build the docker image and then it runs the script. I was wondering if it makes sense to publish a prebuilt docker image to docker hub so that it doesn't need to be built it every time.

rciovati commented 5 years ago

Hey @abinoda is this something I can help you with? The GitHub Package Registry will be out of beta soon, perhaps it's a good moment to give it a try: https://github.com/features/package-registry

This will become even more important as GitHub Actions will be generally available and will be billed by execution time.

abinoda commented 5 years ago

@rciovati Sure!

mattwelke commented 4 years ago

I think this may not be necessary anymore. I'm working on the github-actions-for-ci lab which uses this action, and it builds it each time, but it appears to run pretty quick. 17s for me today. Perhaps they've optimized GitHub Actions since this issue was opened: