Open jjangga0214 opened 5 years ago
I just ran into a variant of this as well:
To be clear, I don’t need help debugging the reason it’s failing. But I would greatly prefer the action to fail in cases like these.
As long as I’m here: thanks for releasing this action! It’s going to be super helpful for my team.
The example below should not return exit code 0, as
SLACK_BOT_TOKEN
was invalid. However, it actually doesn't throw an error, which caused github's cogniting the result successful.https://github.com/jjangga0214/hasura-cli/runs/240981007#step:6:13
Is this intentional as notificatoin is not core part of CI, which you think shouldn't block other important jobs even if there's an error?