abiosoft / caddy-docker

Docker container for Caddy
https://hub.docker.com/r/abiosoft/caddy/
MIT License
766 stars 314 forks source link

Not able to install plugin dyndns #148

Open reitoo opened 5 years ago

reitoo commented 5 years ago

Hi

I tried to install the caddy plugin dyndns with below command:

`docker build --build-arg \
    plugins=dyndns \
    github.com/abiosoft/caddy-docker.git`

(also tried with plugins=caddy-dyndns)

And got errorplugin not found, here is the full log

`docker build --build-arg     plugins=dyndns     github.com/abiosoft/caddy-docker.git
Sending build context to Docker daemon  97.79kB
Step 1/22 : FROM abiosoft/caddy:builder as builder
 ---> cbef2b88c51c
Step 2/22 : ARG version="0.11.0"
 ---> Using cache
 ---> 99ba41adb3c2
Step 3/22 : ARG plugins="git,filemanager,cors,realip,expires,cache"
 ---> Using cache
 ---> 19ef3b40deb5
Step 4/22 : RUN go get -v github.com/abiosoft/parent
 ---> Running in 4ba062b790dc
github.com/abiosoft/parent (download)
github.com/abiosoft/parent
Removing intermediate container 4ba062b790dc
 ---> fb1596aeb4df
Step 5/22 : RUN VERSION=${version} PLUGINS=${plugins} /bin/sh /usr/bin/builder.sh
 ---> Running in 842d0807221a
Cloning into '/go/src/github.com/mholt/caddy'...
Note: checking out '1f7b5abc80679fb71ee0e04ed98cbe284b1fc181'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

Switched to a new branch 'v0.11.0'
github.com/abiosoft/caddyplug (download)
github.com/abiosoft/errs (download)
github.com/fatih/color (download)
Fetching https://golang.org/x/sys/unix?go-get=1
Parsing meta tags from https://golang.org/x/sys/unix?go-get=1 (status code 200)
get "golang.org/x/sys/unix": found meta tag get.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at https://golang.org/x/sys/unix?go-get=1
get "golang.org/x/sys/unix": verifying non-authoritative meta tag
Fetching https://golang.org/x/sys?go-get=1
Parsing meta tags from https://golang.org/x/sys?go-get=1 (status code 200)
golang.org/x/sys (download)
github.com/abiosoft/errs
github.com/fatih/color/vendor/github.com/mattn/go-isatty
golang.org/x/sys/unix
github.com/abiosoft/caddyplug/internal
github.com/fatih/color/vendor/github.com/mattn/go-colorable
github.com/fatih/color
github.com/abiosoft/caddyplug/caddyplug
fetching missing dependencies: caddy, dnsproviders, hook.pluginloader
github.com/mholt/caddy/vendor/github.com/flynn/go-shlex
github.com/mholt/caddy/vendor/github.com/google/uuid
github.com/mholt/caddy/telemetry
github.com/mholt/caddy/caddyfile
github.com/mholt/caddy
Cloning into '/root/lib/caddy/gopath/src/github.com/caddyserver/dnsproviders'...
github.com/abiosoft/caddyplug (download)
github.com/abiosoft/caddyplug/internal
github.com/abiosoft/caddyplug
done fetching depedencies.

plugin not found
github.com/mholt/caddy/vendor/github.com/flynn/go-shlex
github.com/mholt/caddy/vendor/github.com/google/uuid
github.com/mholt/caddy/telemetry
github.com/mholt/caddy/caddyfile
github.com/mholt/caddy
plugin not found
Cloning into '/go/src/github.com/caddyserver/builds'...
caddymain/run.go:38:2: 
../caddyhttp/dyndns.go:2:10: invalid import path: ""
2018/10/19 16:54:51 exit status 1
exit status 1
The command '/bin/sh -c VERSION=${version} PLUGINS=${plugins} /bin/sh /usr/bin/builder.sh' returned a non-zero code: 1`
abiosoft commented 5 years ago

Which plugin is dydns? I can only see https://caddyserver.com/docs/tls.dns.dyn. And in that case, you should use dyn as the plugin name.

vikas027 commented 5 years ago

I too stumbled on this while trying to use route53 plugin.

hr567 commented 5 years ago

dyndns. Failed to find it. @abiosoft

abiosoft commented 5 years ago

Apparently the fault is from upstream and just been fixed https://github.com/mholt/caddy/pull/2521.

However, since the builder builds from release tags, it would not be available until the next Caddy release.