abiosoft / caddy-docker

Docker container for Caddy
https://hub.docker.com/r/abiosoft/caddy/
MIT License
768 stars 315 forks source link

Docker build failed with DNS provider plugin #185

Closed pointbre closed 5 years ago

pointbre commented 5 years ago

Test with current version failed like the following:

docker rmi -f abiosoft/caddy:builder
docker rmi -f mycaddy:1.0
docker build --no-cache -t mycaddy:1.0 --build-arg plugins=godaddy github.com/abiosoft/caddy-docker.git
...
go: finding golang.org/x/net v0.0.0-20180724234803-3673e40ba225
go: error loading module requirements
error at 'building caddy'
The command '/bin/sh -c VERSION=${version} PLUGINS=${plugins} /bin/sh /usr/bin/builder.sh' returned a non-zero code: 1

Test with 0.11.5 works ok

docker rmi -f abiosoft/caddy:builder
docker rmi -f mycaddy:1.0
git clone https://github.com/abiosoft/caddy-docker.git
cd caddy-docker
git checkout e907805a74facac69aa1ed9ef4d15c6be1b9d9a1
docker build --no-cache -t mycaddy:1.0 --build-arg plugins=godaddy .
  http.timeouts
  http.websocket
  on
  tls
  tls.cluster.file
  tls.dns.godaddy
...
Successfully built 19ab5b414a64
Successfully tagged mycaddy:1.0
abiosoft commented 5 years ago

Not all plugins support Go modules yet. You don't have to checkout an old version. You can always do.

docker rmi -f abiosoft/caddy:builder
docker rmi -f mycaddy:1.0
docker build --no-cache -t mycaddy:1.0 --build-arg version=0.11.5 --build-arg plugins=godaddy github.com/abiosoft/caddy-docker.git
NEXUS2345 commented 5 years ago

As @abiosoft said, it appears that most of the DNS provider plugins won't work yet, because their dependencies such as the Go API modules needed to connect to the providers aren't yet updated for Go modules.

pointbre commented 5 years ago

I'm confirming docker build --no-cache -t mycaddy:1.0 --build-arg version=0.11.5 --build-arg plugins=godaddy github.com/abiosoft/caddy-docker.git works well. Thanks for your support.