colima start CLI ignores --mount-type when qemu is chosen

75th commented 1 year ago

Description

colima start --vm-type qemu uses 9p as the mount type, even if you also specify --mount-type virtiofs. It is only possible to create a new profile with both qemu and virtiofs if you pass the -e flag to colima start and edit the config file directly.

Version

Colima Version: 0.5.0 Lima Version: 0.14.1 Qemu Version: 7.2.0 macOS Ventura 13.1

Operating System

[X] macOS Intel
[ ] macOS M1
[ ] Linux

Reproduction Steps

Run colima start profile1 --vm-type qemu -e
See that mountType in the options file is 9p
Save and exit
Run colima start profile2 --vm-type qemu --mount-type virtiofs -e
See that mountType in the options file is 9p
Save and exit
Run colima start profile 3 --vm-type qemu -e
Change the mountType from 9p to virtiofs
Save and exit
Run colima status profile1 and see it using 9p.
Run colima status profile2 and see it using 9p.
Run colima status profile3 and see it using virtiofs.

Expected behaviour

In steps 2, 8, and 10 above, the mountType perhaps should start off as virtiofs.
In steps 5 and 11 above, the mountType definitely should start off as virtiofs.

Additional context

No response

rfay commented 1 year ago

I started a profile with this (macOS arm64):

colima start vz9p -m 6 --mount-type=9p --vm-type=vz --disk=100 --dns 1.1.1.1

and the config file shows the expected

# Default: vz
vmType: vz

# Volume mount driver for the virtual machine (sshfs, 9p).
#
# 9p is more POSIX compliant and generally handles file permissions better.
# However, it does not properly resolve symlinks (that are created on host).
#
# sshfs is faster than 9p but less reliable when there are lots
# of concurrent reads or writes.
#
# Default: sshfs
mountType: 9p

However, the behavior is as described here, it actually has the virtiofs mount type instead of 9p.

$ ddev ssh
rfay@d9-web:/var/www/html$ df -T .
Filesystem     Type      1K-blocks       Used Available Use% Mounted on
mount0         virtiofs 1948455240 1080547296 867907944  56% /var/www/html

abiosoft commented 1 year ago

Thanks for reporting this, it would be investigated. Actually, 9p is not usable with vz and virtiofs is not usable with qemu. Only sshfs is usable for both vm types.

There is indeed an oversight in the documentation in the YAML file as well that needs to be updated.

Thanks.

abiosoft / colima