abiosoft / ishell

Library for creating interactive cli applications.
MIT License
1.68k stars 195 forks source link

Not friendly to non ascii characters #143

Open josedelinux opened 3 years ago

josedelinux commented 3 years ago

hello.go

package main

import (
    "strings"

    "gopkg.in/abiosoft/ishell.v2"
)

func main() {
    // create new shell.
    // by default, new shell includes 'exit', 'help' and 'clear' commands.
    shell := ishell.New()

    // display welcome info.
    shell.Println("Sample Interactive Shell")

    // register a function for "greet" command.
    shell.AddCmd(&ishell.Cmd{
        Name: "greet",
        Help: "greet user",
        Func: func(c *ishell.Context) {
            c.Println("Hello", strings.Join(c.Args, " "))
        },
    })

    // run shell
    shell.Run()
}

when i run it: '''

greet josé Error: Uknown rune: 233

'''

system: windows 10

and i also tried that accents works fine with "github.com/abiosoft/readline"

fy0 commented 2 years ago

+1