search

abique / vst-bridge

VST bridge for Windows vst on Linux
MIT License
272 stars 19 forks source link

Allow user to use their chosen WINEPREFIX for each bridge #12

Closed michalrus closed 9 years ago

michalrus commented 9 years ago

Additionally, I cleaned up and secured templating a bit.

@abique, I'm not quite sure about your branching, but xembed is chosen as the main one, so I'm submitting this PR onto xembed.

@abique, please review and merge.

michalrus commented 9 years ago

@abique, or is it master again? I could swear it was xembed only a while ago. Do you want me to rebase and resubmit onto master, then?

abique commented 9 years ago

I haven't tried, but I believe you did ;-)

abique commented 9 years ago

Thanks!

abique commented 9 years ago

Yes please can you rebase on master and make an other pull request? Thanks :+1:

michalrus commented 9 years ago

Sure. =)

abique commented 9 years ago

By the way have you tried the project air wave? It should be a better vst-bridge. https://github.com/phantom-code/airwave

michalrus commented 9 years ago

@abique, there #13 is this PR, but on master.

Oh, I'll take a look at it, thank you. :)

By the way, what's the purpose of xembed branch? It's exactly the same as master, maybe you could delete it? =)

abique commented 9 years ago

The purpose was to use xembed to solve some mousing issues. But I never managed to get it working.

michalrus commented 9 years ago

Kay, get it. But then, maybe the branch shouldn't be on GH, I dunno. =) Anyway, thanks for merging and for pointing to phantom-code/airwave!

michalrus commented 9 years ago

And thanks for deleting xembed. :heart:

abique commented 9 years ago

You're welcome.

abique commented 9 years ago

By the way are you interested in participating to u-he linux beta test? If so you can send an email to support@u-he.com with the subject "Linux Beta Testing".

michalrus commented 9 years ago

@abique, but would I be then required to submit some review somewhere?

abique commented 9 years ago

Come on IRC to #u-he @ irc.freenode.org, we can talk.

michalrus commented 9 years ago

@abique, so, while airwave has better mouse support (you can change the parameters in plugins window, while playing the project, without gzzhzhzhzhz sound)… I've found some issues: https://github.com/phantom-code/airwave/issues