abishekatp / stylers

Fully compile time scoped CSS for Leptos components
MIT License
139 stars 13 forks source link

fix: make this work on stable rustc #17

Closed M1cha closed 1 year ago

M1cha commented 1 year ago

get: We're using proc_macro2 already so I don't see any harm in using it's implemenation for that.

extend_one: The nightly implemenation just calls extend(Some(x)) anyway so there's no use in using it until it's actually stable.

abishekatp commented 1 year ago

Thank you, I will just check one time locally and merge it.

abishekatp commented 1 year ago

Sorry for this but I think this still works only on nightly version of rust. As mentioned here it will work on only on nightly version when used with procedural macro context. try printing out start and end values on the stable channel of rust it will always return value 0. so it will fail the test case.

M1cha commented 1 year ago

you're right. It looks like I was testing stuff without whitespace only. You could actually just force stable users to quote their stuff to work around that :thinking:

abishekatp commented 1 year ago
M1cha commented 1 year ago

I agree that - as is - this PR doesn't work. I'm using nightly now :shrug: