search

abisoft / Tippy

0 stars 0 forks source link

Code Path Pre-homework #1

Open abisoft opened 8 years ago

abisoft commented 8 years ago

My app is complete. Please review @codepathreview

chieger commented 8 years ago

Hi Mizuho,

I am unable to link to the gif link provided. Please upload gif to imgur.com and display in README using ![description](gifURL).

Also, make sure to add xs in the README file to indicate which features you added to app.

Can you make those changes and add a comment to this issue when finished?

Charlie CodePath

abisoft commented 8 years ago

Hi Charlie,

Thank you for mention me this. I have been super busy for my finals and didn't have time for making changes. I will fix problems and push to github asap.

Thank you!

Mizuho

On Fri, Dec 18, 2015 at 9:38 AM, Charlie Hieger notifications@github.com wrote:

Hi Mizuho,

I am unable to link to the gif link provided. Please upload gif to imgur.com and display in README using description.

Also, make sure to add xs in the README file to indicate which features you added to app.

Can you make those changes and add a comment to this issue when finished?

Charlie CodePath

— Reply to this email directly or view it on GitHub https://github.com/abisoft/Tippy/issues/1#issuecomment-165849275.

kmolo commented 8 years ago

@abisoft you also could change the filename in your README.md

-- the file you uploaded inside your repo is named tippy.gif -- but your README is called for tippy2.gif

...so either update your README to:

![walkthrough][tippy.gif]

...or add tippy2.gif into your repo

chieger commented 8 years ago

Please add a comment to this issue as soon as you update your README file and fix the gif link. I think what is happening with the gif link is that you uploaded the file somewhere in github where I don't have permission to view. Use imgur.com instead to host your gifs.

Also, make sure that you follow the submission instructions carefully.

Thanks, Charlie