search

abivia / ledger

General Ledger and Journal Accounting Package and API for Laravel
MIT License
102 stars 23 forks source link

fix default value pageSize #8

Closed lewrq closed 1 year ago

lewrq commented 1 year ago

The "account/query" method didn't work, the error was "$pageSize should not be available before initialization in the file" Add default value pageSize and fixe validate rule limit

instancezero commented 1 year ago

Hi @lewrq, thanks for your submission. Your changes to AccountQuery defeat API limit enforcement. It is sufficient to initialize pageSize in LedgerRules. Feel free to resubmit this patch with an initial page limit of 25.

lewrq commented 1 year ago

fixed default pageSize to 25

abivia commented 1 year ago

Merged. Thanks!