bug fixes for chrome under unity (ubuntu)

abiyani / automate-save-page-as

Automate browser's "Save Page As" operation

Apache License 2.0

167 stars 50 forks source link

bug fixes for chrome under unity (ubuntu) #12

Open ghost opened 7 years ago

ghost commented 7 years ago

Bug fixes for chrome under unity (ubuntu): removes the command popup, removes switching to text mode. Fixes issue #11 .

abiyani commented 7 years ago

@kadaj : Thanks for the PR. I am busy with several other stuff right now, so won't have chance to review it immediately (btw, at the minimum I would like to have the commits squshed into one, but I will reply with other comments when I get chance for a proper review). Also I am little concerned about special casing for a lot of different platforms, so would like to think about a possible way to handle them more generically.

ghost commented 7 years ago

@abiyani I have squashed the commits and made it more generic. Removed OS specific version check and used XDG_CURRENT_DESKTOP to detect Unity. Let me know about any changes required after the review.