search

abjerner / Skybrud.Social.Umbraco

Package for the Umbraco 7 backoffice that integrates with Skybrud.Social https://github.com/abjerner/Skybrud.Social
MIT License
18 stars 8 forks source link

Fix scope selection #15

Closed bjarnef closed 7 years ago

bjarnef commented 7 years ago

Issue: https://github.com/abjerner/Skybrud.Social.Umbraco/issues/14

Fixed selection of scopes by clicking labels in Facebook OAuth scopes dialog and changes Google to similar naming.

Ensure label use full width of the row cell and added a class to selected scope rows.

abjerner commented 7 years ago

Looks awesome - thanks for helping out :D

There was still a bit of the <td> that wasn't clickable due to it's padding, so I've committed a fix that moves the padding to the <label> instead.

bjarnef commented 7 years ago

Yes, as an alternative the row could have just one cell and extra left padding.. And the checkbox could be moved inside the label.. I think a few pixel around the checkbox is not clickable, because the table cell not is clickable :)

abjerner commented 7 years ago

@bjarnef Yeah, was actually looking into that now :D