search

abjerner / Skybrud.Social.Umbraco

Package for the Umbraco 7 backoffice that integrates with Skybrud.Social https://github.com/abjerner/Skybrud.Social
MIT License
18 stars 8 forks source link

Changed Twitter UserId to a string rather than long #18

Closed seanoldfield closed 7 years ago

seanoldfield commented 7 years ago

Recently had an issue with a clients Twitter account where the id was 18 characters long so the value was being rounded due to the JavaScript limitation on Number size causing an invalid Id to be stored in the database

I have amended so that the TwitterOAuthData model has a string property for the Id of the account which allows the value to be parsed correctly in the JavaScript controller

abjerner commented 7 years ago

Sorry for the lack of reply - I thought I had time to get back to you sooner.

I have now merged your changes, and will look into pushing a new release ;)

Thanks a lot for the help 👍

abjerner commented 7 years ago

Again sorry for the waiting time. I didn't have the time to catch up over the summer, but I've now pushed a new release that includes this pull request:

https://github.com/abjerner/Skybrud.Social.Umbraco/releases/tag/v1.0.7