search

abjerner / Skybrud.Social.Umbraco

Package for the Umbraco 7 backoffice that integrates with Skybrud.Social https://github.com/abjerner/Skybrud.Social
MIT License
18 stars 8 forks source link

converted project to class library #5

Closed EnterpriseWide closed 9 years ago

EnterpriseWide commented 9 years ago

In case your interested, I have updated the project to a class library

abjerner commented 9 years ago

Hi,

I'm not sure I understand why you have converted the project to a class library. The project has quite a few web files (js, apsx etc.), and the project being a web project generally makes things easier in Visual Studio.

You mentioned in #3 that is was to use in one of your own projects. What kind of project is this? I have no problems adding a reference to Skybrud.Social.Umbraco.

EnterpriseWide commented 9 years ago

I added the source code project to my own project because I had to make some changes but you implemented them a few days ago so I got to pull it out and just use a compiled version :) yah! The reason I made it a class library in case your wondering though is because it was affecting my build process stuff. If its a web site project then it expects some funky publishing files to be present. Class Libraries don't need that. Anyway, thanks again.

I am using your project to build this page http://www.pampas.com.au/inspiration/ and we have another one coming out soon which uses facebook. It will be combining items from multiple social sources later.

Regards

On Wed, Feb 25, 2015 at 11:17 PM, Anders Bjerner notifications@github.com wrote:

Hi,

I'm not sure I understand why you have converted the project to a class library. The project has quite a few web files (js, apsx etc.), and the project being a web project generally makes things easier in Visual Studio.

You mentioned in #3 https://github.com/abjerner/Skybrud.Social.Umbraco/issues/3 that is was to use in one of your own projects. What kind of project is this? I have no problems adding a reference to Skybrud.Social.Umbraco.

— Reply to this email directly or view it on GitHub https://github.com/abjerner/Skybrud.Social.Umbraco/pull/5#issuecomment-75950497 .

[image: Liquid Visual] http://ewide.com.au/Ben NormanWeb Developer / .NET Specialiste support@ewide.biz t (+61) 404 828 246 w ewide.com.au

abjerner commented 9 years ago

As the code is structured now, it would be easier for me to maintain as a web project (due to web files), so for now I will have to reject your pull request.

A plan for the future is however to separate the code into two separate projects - a class library only containing the C# classes, and web project containing JavaScript and CSS as well as .aspx files (and code-behind classes related to those). I haven't yet decided how I want to proceed, but there is a good chance that I will settle with this structure.