Closed digiogo closed 8 years ago
Hi, and again thanks for your contributions ;)
Business pages I have already looked a bit into the your logic for business pages (George pointed me to your fork). I haven't had the time to play around with it yet, but the code seems fine ;)
To keep things simple, I'll probably add it as another data type instead since most users may not need it (I haven't had any requests to add support for it before). I'll look into merging your changes when I can find the time ;)
Permissions I hate to spoil your work on this, but I have actually already been working on something similar. But since my work requires changes in both Skybrud.Social and this package, I haven't committed any of my changes yet (sorry).
Currently I have something like this:
This will be incorporated for the other services as well - eg. Google:
The way it works (or will work once done) is that known scopes will be added as constants in Skybrud.Social (including descriptions and more read-friendly names), and then for the pre-value options, new scopes can be added by clicking the green "plus" button, and then selecting the scopes from a list in a dialog / sidebar.
Hello, sorry for delay.
About permissions editor your version is really nice and I appreciate you are finishing it. So it will be very beautiful and useful for most people.
But about Facebook business page I'd like to suggest you to merge it (when you have time) in current datatype because the changes are minimal even though people have not requested. I think add it as a new datatype will duplicate code or will not be flexible enough.
Anyway, thanks for your comments and for your project!
@abjerner any eta on merging the business pages part?
@digiogo @TimGeyssens Sorry for the waiting time. We don't use this package ourselves at Skybrud.dk, so I usually end up working on something more important, resulting in this package being neglected for periods of months.
The good thing is that I now took the time to merge the pull request, and push the changes for the Facebook property/prevalue editor I had been working on.
The updated prevalue editor now looks this:
Clicking the +
button will reveal a dialog looking like the screenshot below. The list of scopes are currently hardcoded in the package, but the plan is they will come from Skybrud.Social in the future, where they will be kept up-to-date.
You're more than welcome to help test the new changes. I have done some quick testing in the new Umbraco 7.4, and all seems to working fine. I will look into releasing a new package in the coming days ;)
That looks awesome, thanks for the effort! Will definitely give it a test in the following days.
v1.0.3
has now been release on NuGet, Our Umbraco and here on GitHub: https://github.com/abjerner/Skybrud.Social.Umbraco/releases/tag/v1.0.3
Please let me know if you experience any problems with the new version ;)
Woot awesome work!
Hello again abjerner!
I've extend your Facebook OAuth datatype to achieve the following functionalities: