abjerner / Skybrud.Social.Umbraco

Package for the Umbraco 7 backoffice that integrates with Skybrud.Social https://github.com/abjerner/Skybrud.Social
MIT License
18 stars 8 forks source link

oAuth WIndow callback in Internet Explorer #7

Open smokeyjohnson opened 8 years ago

smokeyjohnson commented 8 years ago

It appears that by default security settings (protected mode) in Internet Explorer stop the callback from happening from the child window to the parent. The Umbraco property editor is never updated. This appears to be a widespread issue with Window communication in protected mode. Is there a more reliable way of doing this rather than using a callback from the child window?

A number of options seem to be around but all none of them seem to get around this issue; Like using a timer in the parent window and checking the window.location of the child window to see when it has returned from the external Twitter url... and then grabbing the result... but again when the window redirects to an external (https?) url, the handle on the window seems to change and a permission denied error results (which can be caught). However even when the window returns to the same domain as the parent, Internet Explorer still doesn't seem to make the window handle object fully available again.

Apart from redirecting the entire page to the Twitter authorisation page and then back I can't seem to find a fully cross browser reliable way of doing this in-line (and a full page redirect wouldn't really be acceptable in the Umbraco backend).

abjerner commented 8 years ago

Hi and thanks for reporting,

I can confirm the issue, but the window callback seems to be working fine (default settings in IE11).

What seems to be the problem is instead that AngularJS doesn't trust the data from the postback, and therefore triggers an error. I don't have a solution at the moment, but will look further into it ;)