abkfenris / xarray_fmrc

A way to manage forecast Xarray datasets using datatrees
MIT License
14 stars 2 forks source link

How to best handle dimensions that dont match the names assumed? #10

Closed mpiannucci closed 1 year ago

mpiannucci commented 1 year ago

Im currently working on getting FMRC views to work with my kerhcunked DBOFS dataset. From what I am reading, I am seeing that the time dimension needs to be named time, is that correct?

For these datasets, the time var is named ocean_time, but has a standard_name of time. Just wanted to ask what you think the best way of handling it is, I was trying to not modify the variable names if possible

Dataset: https://nextgen-dmac.s3.amazonaws.com/nos/nos.dbofs.fields.nc.zarr

github-actions[bot] commented 1 year ago

Hello @mpiannucci, thank you for your interest in our work!

If this is a bug report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

mpiannucci commented 1 year ago

Screenshot 2023-03-17 at 10 30 41 AM

abkfenris commented 1 year ago

Ok, I've got a PR (#11) that should be able to handle if the time dimension is named something different, and doesn't require forecast_reference_time to be baked into each dataset within the datatree. I need to update the docs to handle that.